Opened 6 years ago

Closed 6 years ago

#115 closed defect (fixed)

Verify that recommended consistency checking algorithm is correct

Reported by: eranm@… Owned by: katjoyce@…
Priority: major Milestone: review
Component: rfc6962-bis Version:
Severity: - Keywords:
Cc:

Description

The algorithm in https://tools.ietf.org/html/draft-ietf-trans-rfc6962-bis-10#section-9.4.2 is somewhat open to interpretation and may not handle all edge cases.
We should make sure that the pitfalls are well documented and all edge cases are accounted for.

Change History (11)

comment:2 Changed 6 years ago by eranm@…

Sorry, should have been clearer: I have no doubt the algorithm is correct, however I managed to interpret it in a way that is not :)
So I'd like lo go over the code vs. the document to clarify the points where I mis-interpreted the text.

comment:3 Changed 6 years ago by katjoyce@…

  • Owner changed from draft-ietf-trans-rfc6962-bis@… to katjoyce@…

Eran has fixed this for consistency proofs but has not yet checked inclusion proofs - I will do that.

comment:4 Changed 6 years ago by katjoyce@…

Inclusion proof description exactly matches code, with no room for interpretation.

comment:5 Changed 6 years ago by katjoyce@…

  • Resolution set to fixed
  • Status changed from new to closed

comment:6 Changed 6 years ago by katjoyce@…

  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:7 Changed 6 years ago by eranm@…

  • Milestone set to review

comment:8 Changed 6 years ago by eranm@…

  • Milestone review deleted

Removing review milestone.
Per offline clarification, we should make sure that the test cases in test_rfc_algorithms.py cover positive and negative cases (by copying the concepts from https://github.com/google/certificate-transparency/blob/master/cpp/merkletree/merkle_tree_test.cc) then make sure the algorithm identifies both success and failure correctly.

comment:10 Changed 6 years ago by katjoyce@…

  • Milestone set to review

comment:11 Changed 6 years ago by melinda.shore@…

  • Resolution set to fixed
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.