Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#522 closed editorial (incorporated)

Gen-art review of draft-ietf-httpbis-p7-auth-25

Reported by: julian.reschke@… Owned by: draft-ietf-httpbis-p7-auth@…
Priority: normal Milestone: 26
Component: p7-auth Severity: In IESG Evaluation
Keywords: Cc:

Description (last modified by julian.reschke@…)

Document: draft-ietf-httpbis-p7-auth-25 Reviewer: Kathleen Moriarty Review Date: November 18, 2013 IETF LC End Date: IESG Telechat date: 12/19

Summary: The draft is ready from a Gen-art perspective with a few nits to resolve. I also added a security consideration with suggested text below.

Minor issues:


~In section 2.1, in third to last paragraph, why is ought used here instead of a keyword? This is a point that could help with interoperability, so I think a keyword is important. Unless there is another error message, one should be provided when the role access requirements are not met. Users would expect this functionality. - see http://lists.w3.org/Archives/Public/ietf-http-wg/2013OctDec/1147.html


Nits/editorial comments:


Section 3.2.1 - please fix the run-on sentence, the first one as it is difficult to read. Suggestion: From:

If a server receives a request for an access-protected object, and an acceptable Authorization header is not sent, the server responds with a "401 Unauthorized" status code, and a WWW-Authenticate header as per the framework defined above, which for the digest scheme is utilized as follows:

To:

If a server receives a request for an access-protected object and an acceptable Authorization header is not sent. The server responds with a "401 Unauthorized" status code and a WWW-Authenticate header as per the framework defined above. For the digest scheme, this is utilized as follows: -- see http://lists.w3.org/Archives/Public/ietf-http-wg/2013OctDec/1147.html


Section 4.1, second to last paragraph. Please consider rewording the content in parenthesis, it is difficult to read and probably found just be a separate sentence rather than included with the prior sentence in parenthesis.

"If a request is authenticated and a realm specified, the same credentials are presumed to be valid for all other requests within this realm (assuming that the authentication scheme itself does not require otherwise, such as credentials that vary according to a challenge value or using synchronized clocks)."

I believe the paragraph is fine the way it is right now.


Section 4.2, second paragraph, consider breaking the following sentence into two:

From:

However, if a recipient proxy needs to obtain its own credentials by requesting them from a further outbound client, it will generate its own 407 response, which might have the appearance of forwarding the Proxy-Authenticate header field if both proxies use the same challenge set.

To:

However, if a recipient proxy needs to obtain its own credentials by requesting them from a further outbound client, it will generate its own 407 response. This might have the appearance of forwarding the Proxy-Authenticate header field if both proxies use the same challenge set. - [2500]


Section 4.4, the last paragraph could be read more clearly with the following change:

From:

This header field contains two challenges; one for the "Newauth" scheme with a realm value of "apps", and two additional parameters "type" and "title", and another one for the "Basic" scheme with a realm value of "simple".

To:

This header field contains two challenges; one for the "Newauth" scheme with a realm value of "apps" and two additional parameters "type" and "title", and the second for the "Basic" scheme with a realm value of "simple". - see http://lists.w3.org/Archives/Public/ietf-http-wg/2013OctDec/1147.html


Section 6: Security Considerations

Could you add in text to inform developers that content should not be accessed before authentication occurs when required? I know this sounds obvious, but I recently ran into this issue. On a Mac, I am able to see that the application server/database information is actually loaded before I authenticate (sure there is a SQL injection happening here too) and the screen is slightly greyed out. On a PC, it appears to block access, but this is a display thing rather than requiring the authentication to actually work prior to serving content.

Perhaps something like the following:

When a web service is configured to use authentication, content from the application server requiring authentication MUST not be accessed until the authentication has completed successfully. - see http://lists.w3.org/Archives/Public/ietf-http-wg/2013OctDec/1147.html

Change History (9)

comment:1 Changed 6 years ago by julian.reschke@…

From [2500]:

tiny rephrasing (see #522)

comment:2 Changed 6 years ago by julian.reschke@…

  • Milestone changed from unassigned to 26
  • Severity changed from In IETF LC to In IESG Evaluation

comment:3 Changed 6 years ago by julian.reschke@…

  • Description modified (diff)
  • Type changed from design to editorial

comment:4 Changed 6 years ago by julian.reschke@…

  • Description modified (diff)

comment:5 Changed 6 years ago by julian.reschke@…

  • Description modified (diff)

comment:6 Changed 6 years ago by julian.reschke@…

  • Description modified (diff)

comment:7 Changed 6 years ago by mnot@…

Re: 4.1, I don't see any way to improve.

comment:8 Changed 6 years ago by julian.reschke@…

  • Description modified (diff)
  • Resolution set to incorporated
  • Status changed from new to closed

comment:9 Changed 6 years ago by fielding@…

From [2558]:

(editorial) rephrase the description of proxy chaining in Proxy-Authenticate; see #522 and #536

Note: See TracTickets for help on using tickets.