Opened 5 years ago
Last modified 3 years ago
#21869 closed enhancement
A framework for discrete valuations in Sage — at Version 22
Reported by: | saraedum | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-7.5 |
Component: | commutative algebra | Keywords: | discrete valuations, valuations, p-adics, function fields, number fields, smooth projective curves, Mac Lane algorithm, Montes algorithm, sd87 |
Cc: | Merged in: | ||
Authors: | Reviewers: | ||
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
This is a meta-ticket to keep track of the progress of integrating https://github.com/saraedum/mac_lane into Sage.
Fix bugs in Sage
There are a number of trivial bugs that get fixed by monkey-patches in https://github.com/saraedum/mac_lane/blob/master/__init__.py
- Conversion from a Function Field to its Constant Field #21872
- Conversion from a Function Field to its underlying Polynomial Ring #23166
- Coercions between Function Fields #23167
- Coercions are injective if the underlying map is #21879
- Ring homomorphisms from Fields are injective #21879
- Polynomial rings embed into their fraction fields #23185
The embedding of a ring into a polynomial ring over that ring is injective- p-adic rings embed into their fraction fields #23188
- Morphisms of number fields are injective #21879
- ZZ into QQ is injective #21879
- quotients of polynomial rings are injective/surjective #23190
- ZZ into a Number Field is injective #21879
- ZZ into an order of a Number Field is injective #21879
- ZZ does not map onto QQ #23186
ZpCA shifts are broken- add default implementation of inverse_of_unit() #23191
- (some_elements() should return more than just [1] for most rings.)
Add new features to Sage
New features that the code needs to work
- Factorization over iterated extensions of finite fields. #21996
principal_part() and sides() of a Newton Polygon(patch this in the calling code instead.)- (cached_in_argument_method #22034)
Make tests non-trivial
- (some_elements() should be non-trivial for number fields/orders)
- (some_elements() should be non-trivial/deterministic for rational function fields and their extensions)
- (some_elements() should be non-trivial for fraction_fields of polynomial rings)
Add the valuation code to Sage
i.e., add these files https://github.com/saraedum/mac_lane to Sage.
Change History (22)
comment:1 Changed 5 years ago by
- Description modified (diff)
comment:2 Changed 5 years ago by
- Description modified (diff)
comment:3 Changed 5 years ago by
- Description modified (diff)
comment:4 Changed 5 years ago by
- Description modified (diff)
comment:5 Changed 5 years ago by
- Description modified (diff)
comment:6 Changed 5 years ago by
- Description modified (diff)
comment:7 Changed 5 years ago by
- Description modified (diff)
comment:8 Changed 5 years ago by
- Description modified (diff)
comment:9 Changed 4 years ago by
- Description modified (diff)
comment:10 Changed 4 years ago by
- Description modified (diff)
comment:11 Changed 4 years ago by
- Description modified (diff)
comment:12 Changed 4 years ago by
- Description modified (diff)
comment:13 Changed 4 years ago by
- Description modified (diff)
comment:14 Changed 4 years ago by
- Description modified (diff)
comment:15 Changed 4 years ago by
- Description modified (diff)
comment:16 Changed 4 years ago by
- Description modified (diff)
comment:17 Changed 4 years ago by
- Description modified (diff)
comment:18 Changed 4 years ago by
- Description modified (diff)
comment:19 Changed 4 years ago by
- Description modified (diff)
comment:20 Changed 4 years ago by
- Description modified (diff)
comment:21 Changed 4 years ago by
- Description modified (diff)
comment:22 Changed 4 years ago by
- Description modified (diff)
Note: See
TracTickets for help on using
tickets.